DAOS-17938 pool: Add degraded to query output #17371

liw · 2026-01-13T06:47:33Z

Add the following to pool query output (shown as dmg pool query output):

- Data redundancy: degraded

When data redundancy is intact, "normal" is shown instead of "degraded".

Features: control pool

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

github-actions · 2026-01-13T06:47:49Z

Ticket title is 'dmg pool query should show that there are ranks that are DOWN but not DOWNOUT'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-17938

daosbuild3 · 2026-01-13T08:26:57Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17371/2/testReport/

daosbuild3 · 2026-01-13T16:45:17Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17371/2/display/redirect

daosbuild3 · 2026-01-13T17:37:25Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17371/2/execution/node/1350/log

Add the following to pool query output (shown as dmg pool query output): - Data redundancy: degraded When data redundancy is intact, "normal" is shown instead of "degraded". Features: control pool Signed-off-by: Li Wei <[email protected]>

daosbuild3 · 2026-01-13T23:53:15Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17371/2/execution/node/1335/log

liw · 2026-01-13T23:57:47Z

Requesting reviews a bit early, since I'm not that familiar with the areas being changed.

daosbuild3 · 2026-01-14T01:03:14Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17371/3/testReport/

tanabarr · 2026-01-14T10:14:38Z

src/include/daos_pool.h

+/** For daos_rebuild_status.rs_flags */
+enum daos_rebuild_status_flag {
+	/** Data redundancy degraded (the pool has one or more DOWN targets) */
+	DAOS_RSF_DEGRADED = (1 << 0),


what is the point of shifting by zero bits?

@tanabarr, just a style. :) See line 156 of this header, for example:
DPI_SPACE = 1ULL << 0,

tanabarr · 2026-01-14T10:23:54Z

src/mgmt/srv_drpc.c

 	else
 		rebuild->state = MGMT__POOL_REBUILD_STATUS__STATE__BUSY;
+
+	rebuild->degraded = !!(info->rs_flags & DAOS_RSF_DEGRADED);


what is the point of the double negation here? is it equivalent to ... != 0?

@tanabarr, it's an idiom (or pattern, at least) for converting a nonzero number to 1, usually used on flags. For example---I've seen this a couple of times in my career---say, the flags are uint64_t, and the result of the & is 0x100000000, if assigned to a uint32_t, the value overflows and becomes 0!

And yes, it's the same as != 0.

mchaarawi

the C & API changes look good to me.
not sure about all the control changes.

daltonbohning

ftest LGTM. The rs_padding16 seemed unused anyway

liw · 2026-01-15T01:14:45Z

Mohamad, Dalton, thank you for the quick reviews. I'll wait for one additional reviewer.

daosbuild3 · 2026-01-15T13:55:25Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17371/3/execution/node/1283/log

liw · 2026-01-16T06:50:38Z

Two simple regressions (expected pool query results of two tests need updating) need to be fixed:

control/dmg_pool_query_test
- basic: regression
- ior: SRE-3525
dfuse/daos_build: likely SRE-3525 slowness
- / FTEST_launch: likely CI issue "Error determining if /mnt/share/tmp.Dm0r7JNoE2/valgrind* files exist on opa-112"
nvme/pool_capacity: likely CI issue "ssh: connect to host opa-114 port 22: No route to host"
pool/list_verbose: regression
rebuild/mdtest: likely CI issue '"the server could not be reached at the configured address (opa-112:10001)": unable to contact the DAOS Management Service"'

Signed-off-by: Li Wei <[email protected]>

Features: control pool

Features: control pool Signed-off-by: Li Wei <[email protected]>

daosbuild3 · 2026-01-16T20:34:15Z

Test stage Functional Hardware Large MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17371/6/testReport/

daosbuild3 · 2026-01-17T05:50:20Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17371/6/testReport/

Features: control pool Signed-off-by: Li Wei <[email protected]>

Features: control pool

liw · 2026-01-19T01:23:06Z

One rebuild case in pool/list_verbose needs a further update. The container/boundary space errors do not seem to be related to this PR; I've filed DAOS-18477 for them.

daosbuild3 · 2026-01-19T02:49:38Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17371/7/testReport/

liw force-pushed the liw/pool-query-out-pad branch from cfab5bf to 2f86dcb Compare January 13, 2026 07:36

DAOS-17938 pool: Add degraded to query output

cf277d5

Add the following to pool query output (shown as dmg pool query output): - Data redundancy: degraded When data redundancy is intact, "normal" is shown instead of "degraded". Features: control pool Signed-off-by: Li Wei <[email protected]>

liw force-pushed the liw/pool-query-out-pad branch from 2f86dcb to cf277d5 Compare January 13, 2026 23:51

liw marked this pull request as ready for review January 13, 2026 23:55

liw requested review from a team as code owners January 13, 2026 23:55

liw requested review from kccain, mchaarawi and tanabarr January 13, 2026 23:56

tanabarr previously approved these changes Jan 14, 2026

View reviewed changes

mchaarawi previously approved these changes Jan 14, 2026

View reviewed changes

daltonbohning reviewed Jan 14, 2026

View reviewed changes

liuxuezhao previously approved these changes Jan 15, 2026

View reviewed changes

liw added 2 commits January 16, 2026 15:51

Update dmg_pool_query_test.py and list_verbase.py

1a4d6cb

Signed-off-by: Li Wei <[email protected]>

Merge branch 'master' into liw/pool-query-out-pad

eb750f9

Features: control pool

liw dismissed stale reviews from liuxuezhao, mchaarawi, and tanabarr via eb750f9 January 16, 2026 06:52

Fix copyright dates

b5f505d

Features: control pool Signed-off-by: Li Wei <[email protected]>

liw force-pushed the liw/pool-query-out-pad branch from f0c7241 to b5f505d Compare January 16, 2026 06:54

liw added 2 commits January 19, 2026 10:18

Fix pool/list_verbose rebuild case

c885c90

Features: control pool Signed-off-by: Li Wei <[email protected]>

Merge branch 'master' into liw/pool-query-out-pad

2f26285

Features: control pool

DAOS-17938 pool: Add degraded to query output #17371

Are you sure you want to change the base?

DAOS-17938 pool: Add degraded to query output #17371

Conversation

liw commented Jan 13, 2026

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Jan 13, 2026

Uh oh!

daosbuild3 commented Jan 13, 2026

Uh oh!

daosbuild3 commented Jan 13, 2026

Uh oh!

daosbuild3 commented Jan 13, 2026

Uh oh!

liw commented Jan 13, 2026

Uh oh!

daosbuild3 commented Jan 14, 2026

Uh oh!

tanabarr Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

liw Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

liw Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

liw Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

mchaarawi left a comment

Choose a reason for hiding this comment

Uh oh!

daltonbohning left a comment

Choose a reason for hiding this comment

Uh oh!

liw commented Jan 15, 2026

Uh oh!

daosbuild3 commented Jan 15, 2026

Uh oh!

liw commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Jan 16, 2026

Uh oh!

daosbuild3 commented Jan 17, 2026

Uh oh!

liw commented Jan 19, 2026

Uh oh!

daosbuild3 commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Jan 13, 2026 •

edited

Loading

liw commented Jan 16, 2026 •

edited

Loading